Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support dispatcher format for triggers #8151

Merged

Conversation

Cali0707
Copy link
Member

Fixes #8077

Proposed Changes

  • Add delivery format to the trigger CRD
  • Use the trigger format when sending to the trigger subscriber

Pre-review Checklist

  • At least 80% unit test coverage
  • E2E tests for any new behavior
  • Docs PR for any user-facing impact
  • Spec PR for any new API feature
  • Conformance test for any change to the spec

Release Note

Triggers referencing MTChannelBased Brokers now support the Delivery Format option

Signed-off-by: Calum Murray <cmurray@redhat.com>
Signed-off-by: Calum Murray <cmurray@redhat.com>
@knative-prow knative-prow bot requested review from creydr and matzew August 12, 2024 15:13
@knative-prow knative-prow bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Aug 12, 2024
@Cali0707
Copy link
Member Author

/cc @creydr

One question I had here is should we also use the delivery format when delivering to the DLS?

Copy link

codecov bot commented Aug 12, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.44%. Comparing base (bf945f9) to head (4eba0b5).
Report is 4 commits behind head on main.

Files Patch % Lines
pkg/broker/filter/filter_handler.go 42.85% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           main    #8151       +/-   ##
=========================================
+ Coverage      0   67.44%   +67.44%     
=========================================
  Files         0      371      +371     
  Lines         0    18006    +18006     
=========================================
+ Hits          0    12145    +12145     
- Misses        0     5087     +5087     
- Partials      0      774      +774     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@knative-prow knative-prow bot added area/test-and-release Test infrastructure, tests or release size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 19, 2024
@Cali0707
Copy link
Member Author

/cc @pierDipi @creydr

This should be ready for review & has an e2e test now

@knative-prow knative-prow bot requested a review from pierDipi August 19, 2024 14:49
@Cali0707
Copy link
Member Author

/test upgrade-tests

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Aug 22, 2024
Copy link

knative-prow bot commented Aug 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit da10b71 into knative:main Aug 22, 2024
35 of 36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test-and-release Test infrastructure, tests or release lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delivery format: Support the format field on the trigger delivery spec
2 participants